Fix nil FieldCodec panic #3646
Merged
Fix nil FieldCodec panic #3646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried making a test case for this but it's difficult to reproduce an instance where there would not be metadata for a series. This should at least avoid the panic we were seeing. |
|
+1 |
|
You may wish to update the CHANGELOG @benbjohnson |
This commit changes FieldCodec to always be non-nil. Normally it should always be non-nil, however, if metadata is not persisted correctly or consistently then it could be missing. A nil FieldCodec causes queries to panic. Fixes influxdata#3535
|
@otoolep CHANGELOG updated. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request changes
FieldCodecto always be non-nil. Normally it should always be non-nil, however, if metadata is not persisted correctly or consistently then it could be missing. AnilFieldCodeccauses queries to panic.Fixes #3535