init.d script -- fix issue #3803 #3804
Conversation
| @@ -45,7 +45,7 @@ PIDFILE=/var/run/influxdb/influxd.pid | |||
| PIDDIR=`dirname $PIDFILE` | |||
| if [ ! -d "$PIDDIR" ]; then | |||
| mkdir -p $PIDDIR | |||
| chown $GROUP:$USER $PIDDIR | |||
| chown $USER:$GROUP $PIDDIR | |||
There was a problem hiding this comment.
Thanks to @dgnorton in PR 3115 I realise there was a bug here.
There was a problem hiding this comment.
+1 on this specific change.
|
Well, init scripts aren't my forte, but this all seems to make sense to me. What do you think, @otoolep? |
| @@ -62,6 +62,7 @@ fi | |||
|
|
|||
| if [ ! -f "$STDOUT" ]; then | |||
| mkdir -p $(dirname $STDOUT) | |||
| chown $USER:$GROUP $(dirname $STDOUT) | |||
There was a problem hiding this comment.
Surely not. If STDOUT (and STDERR) are not changed from the defaults, this is changing the owner and group of /dev.
There was a problem hiding this comment.
I.e. it makes no sense to do this, right?
chown influxdb:influxdb /dev
There was a problem hiding this comment.
Opps, that's true, I was trying to fix the corner case when you change from the default user influxdb to another user and the file/directory already exist.
I will revert this change.
|
2 of the changes make sense. The other 2 scare me! |
|
Please let me know if I am missing something here. |
|
Thanks @KoeSystems -- can you squash the 3 changes into 1? |
|
Closed in error. |
|
Thanks @KoeSystems -- merging now. |
init.d script -- fix issue #3803
This bug was introduced in PR 3115.