Fix group by time intervals #4038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -211,11 +211,14 @@ func (q *QueryExecutor) ExecuteQuery(query *influxql.Query, database string, chu | |||
| func (q *QueryExecutor) PlanSelect(stmt *influxql.SelectStatement, chunkSize int) (Executor, error) { | |||
| shards := map[uint64]meta.ShardInfo{} // Shards requiring mappers. | |||
|
|
|||
| // It is important to "stamp" this time so that everywhere we evaluate `now()` in the statement is EXACTLY the same `now` | |||
| now := time.Now().UTC() | |||
There was a problem hiding this comment.
This change wasn't required, but it made sense that any time we use now it's the exact now everywhere.
|
Some important fixes, nice, +1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not properly setting seek/max bounds on cursors of
partialbuckets at the beginning and end of a tmax/tmin bucket.The issue is best illustrated by looking at the added tests.
fixes #3926