Add stats to PointsWriter #4045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otoolep
force-pushed
the
writer_stats
branch
from
403b118
to
880b523
Compare
|
Looks good, should still have @jwilder take a look to confirm the stats line up with what we think they do. |
| statWritePartial = "write_partial" | ||
| statWriteTimeout = "write_timeout" | ||
| statWriteErr = "write_error" | ||
| statWritePointHHReq = "point_hh_req" |
There was a problem hiding this comment.
point_req_hh instead? To match the other 3 patterns.
|
One question but 👍 otherwise. |
otoolep
force-pushed
the
writer_stats
branch
from
880b523
to
e664d2e
Compare
otoolep
force-pushed
the
writer_stats
branch
from
e664d2e
to
f0bbec6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.