allow specifying field name in graphite template #4178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @roobert -- test failures can be seen here: |
|
@otoolep - thanks, any comments on my original post? |
…-custom-field Conflicts: services/graphite/parser.go
|
@otoolep: I think this is ready to be merged, is there anything else I need to do? I've added tests, signed the CLA, and updated the graphite listener This patch doesn't change any existing functionality and doesn't modify the default behaviour of the graphite listener. We've been running this in production for 4 days and all seems good so far with ~40,000 points a second. |
|
cc @jwilder |
|
Looks good @roobert! 👍 |
|
@sparrc - you seem to be working on the graphite parser, is this something you could look into merging? Cheers, |
|
@roobert, looks good, thank you, I can merge this |
|
+1, thanks @roobert |
sparrc
added a commit
that referenced
this pull request
Oct 8, 2015
|
👍 thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial attempt at implementing this: #4176
I'd like some feedback on how this should be implemented, primarily:
fieldtags be allowed, in the same way as themeasurementtag is?mytag.measurement*.fieldfield*be implementedI also obviously need to add some tests but thought I'd try and get a discussion going on implementation first..