Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphite TCP should not block system shutdown #4222

Merged
merged 1 commit into from Sep 28, 2015
Merged

Conversation

otoolep
Copy link
Contributor

@otoolep otoolep commented Sep 24, 2015

With this change Graphite TCP connections are tracked on a per-service
basis. This allows a closing Graphite service to first shutdown any
active connections, thereby unblocking the rest of shutdowm.

This work exposed small shortcomings with the existing Diagnostics
system and that code has alse been tweaked.

Fixes issue #4017

@otoolep
Copy link
Contributor Author

otoolep commented Sep 24, 2015

Diagnostics now on a per-Service basis:

name: graphite:tcp::2004
------------------------
local           remote          connect time
127.0.0.1:2004  127.0.0.1:39541 2015-09-24T20:45:09.677914798Z

name: graphite:tcp::2003
------------------------
local           remote          connect time
127.0.0.1:2003  127.0.0.1:44387 2015-09-24T20:45:10.386430546Z

@otoolep
Copy link
Contributor Author

otoolep commented Sep 24, 2015

@dgnorton

With this change Graphite TCP connections are tracked on a per-service
basis. This allows a closing Graphite service to first shutdown any
active connections, thereby unblocking the rest of shutdowm.

This work exposed small shortcomings with the existing Diagnostics
system and that code has alse been tweaked.

Fixes issue #4017
@otoolep otoolep self-assigned this Sep 26, 2015
@otoolep otoolep added this to the 0.9.5 milestone Sep 26, 2015
@dgnorton
Copy link
Contributor

+1

otoolep added a commit that referenced this pull request Sep 28, 2015
Graphite TCP should not block system shutdown
@otoolep otoolep merged commit 2db82ee into master Sep 28, 2015
@otoolep otoolep deleted the graphite_tcp_blocking branch September 28, 2015 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants