graphite parser: apply tags from the Parser on the template #4364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -157,7 +157,14 @@ func (p *Parser) ApplyTemplate(line string) (string, map[string]string) { | |||
| } | |||
| // decode the name and tags | |||
| template := p.matcher.Match(fields[0]) | |||
| return template.Apply(fields[0]) | |||
| name, tags := template.Apply(fields[0]) | |||
| // Set the default tags on the point if they are not already set | |||
There was a problem hiding this comment.
simply taken from line 139 above: https://github.com/influxdb/influxdb/pull/4364/files#diff-a432a12f1934214ec3298ae02d5e4041R139
sparrc
force-pushed
the
graphite-parser
branch
from
54b1017
to
c2fbf8b
Compare
|
Yes, this should do as the PR title says. +1. |
sparrc
force-pushed
the
graphite-parser
branch
from
c2fbf8b
to
ddd6a16
Compare
sparrc
force-pushed
the
graphite-parser
branch
from
ddd6a16
to
73a630d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to #4348, fix tag parsing behavior