Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intofixes #4454

Merged
merged 2 commits into from Oct 19, 2015
Merged

Intofixes #4454

merged 2 commits into from Oct 19, 2015

Conversation

DanielMorsing
Copy link
Contributor

Fixes that needed for new INTO queries.

@dgnorton

Daniel Morsing added 2 commits October 15, 2015 12:12
For aggregate queries, having a null result means that you haven't
got any data for that time period. CQs used this as a signal that
the measurement was not created and dropped the entire write.

INTO queries can have any structure, including wildcards, so dropping
the entire query isn't going to work. Instead, just drop the nulls
returned.
CQs has a feature where you can tell it to use the name of the originating measurement as the target name. This was missed when I reimplemented it.
vals[fieldName] = v[fieldIndex]
val := v[fieldIndex]
if val != nil {
vals[fieldName] = v[fieldIndex]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ow. :-)

@dgnorton
Copy link
Contributor

+1

@otoolep
Copy link
Contributor

otoolep commented Oct 19, 2015

+1

DanielMorsing added a commit that referenced this pull request Oct 19, 2015
@DanielMorsing DanielMorsing merged commit e73c370 into master Oct 19, 2015
@otoolep otoolep deleted the intofixes branch October 28, 2015 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants