fix subscriber logic when closed #4536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -100,9 +100,10 @@ func (s *Service) waitForMetaUpdates() { | |||
| } else { | |||
| //Check that we haven't been closed before performing update. | |||
| s.mu.Lock() | |||
| if !s.closed { | |||
| if s.closed { | |||
There was a problem hiding this comment.
This makes sense, though I think closed should also be set to true in New Service.
|
+1 on green, with suggested improvement. |
nathanielc
force-pushed
the
nc-fix-subscriptions
branch
from
e02d564
to
7c71ed5
Compare
nathanielc
pushed a commit
that referenced
this pull request
Oct 21, 2015
fix subscriber logic when closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for detecting the closed service was broken. Fixed and added a test.
Also update logging to only log when something changes instead of any time it checks for a change.