Completes lint for meta folder #4705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
@pablolmiranda -- CLA must be signed before this can be merged. +1 from me once that is done. |
| @@ -1200,6 +1200,8 @@ func (s *Store) ShardGroupByTimestamp(database, policy string, timestamp time.Ti | |||
| return | |||
| } | |||
|
|
|||
| // ShardOwner look up for a specific shard and return the shard group information | |||
There was a problem hiding this comment.
Nit: look up for a -> looks up a
|
@otoolep CLA signed. |
|
Thanks @pablolmiranda |
otoolep
added a commit
that referenced
this pull request
Nov 11, 2015
Completes lint for meta folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should the meta/internal/meta.pb.go be part of the repo and not generated as part of the build process?
Part of #4098