Don't display "deleted" shards in SHOW SHARDS output #4725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otoolep
changed the title
Fixes issue #4709.
otoolep
changed the title
otoolep
changed the title
Fixes issue #4727.
|
+1 |
otoolep
added a commit
that referenced
this pull request
Nov 10, 2015
Don't display "deleted" shards in SHOW SHARDS output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a shard's "owning" shard group has been marked as deleted, the shard is, or soon will be, deleted. So don't list shards that are effectively deleted.
The constant for minimum retention policy was also duplicated in the code, and this was a mistake. This PR also fixes that, setting the constant in one place. It also enhances logging, as requested by @beckettsean
Fixes issue #4709.