SHOW SHARD GROUPS #4792
Merged
SHOW SHARD GROUPS #4792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mateuszdyminski -- have you signed the CLA? |
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| ### Features | |||
| - [#4790](https://github.com/influxdb/influxdb/pull/4790): Allow openTSDB point-level error logging to be disabled | |||
| - [#4728](https://github.com/influxdb/influxdb/pull/4728): SHOW SHARD GROUPS | |||
There was a problem hiding this comment.
Please add 'by @mateuszdyminski' to the end of the line. We like to include credits in the CHANGELOG.
|
Looks good @mateuszdyminski -- some small changes required. @dgnorton -- can I get a +1 assuming requested changes are made? |
mateuszdyminski
force-pushed
the
show_shard_groups
branch
from
e2265b1
to
8090ba6
Compare
|
@otoolep I signed the CLA. All comments fixed. |
|
CLA confirmed signed. @dgnorton -- please review and merge if it looks good to you. |
|
+1 |
1 similar comment
|
+1 |
|
Thanks @mateuszdyminski ! |
|
Thanks for help @otoolep. It was my first open-source contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #4728