Fixes #5077

[pires]

Throw an error if NAME is not provided when creating a database with retention, but something else is.

• CHANGELOG.md updated
• Rebased/mergable
• Tests pass
• Sign CLA (if not already signed)

Fixes #5077

[otoolep]

Can we have some tests that don't quote the names?

[pires]

Sure!

[otoolep]

Thanks @pires -- quoting handles some edge cases in our code, and I want to make sure it doesn't confuse anything.

[pires]

@otoolep done.

[otoolep]

+1, thanks @pires

@corylanou @dgnorton ?

[dgnorton]

@pires it's a little confusing but the way this is handled is that each statement parsing method only parses the tokens it needs and leaves everything after it. In the example you gave with REPLICATION 1 presents, The bug is that parseCreateDatabase checks for the NAME token and doesn't p.unscan() when the token is anything other than NAME. It should put the token back in the stream and let the outer parsing loop handle it. Should look like...

// Look for "NAME"
var rpName string = "default" // default is default
if err := p.parseTokens([]Token{NAME}); err == nil {
   rpName, err = p.parseIdent()
   if err != nil {
      return nil, err
   }
} else {
   p.unscan()
}

[pires]

@dgnorton @jsternberg you are right regarding p.unscan(). I will fix this over the next couple days. Thank you!

[pires]

@dgnorton @jsternberg so I push-forced a single commit. This is enough, right?

[dgnorton]

@pires that should fix it. Thanks!

+1 once the tests pass

[jsternberg]

Perfect @pires!

Can you update the changelog with your contribution and the issue it fixes?

[pires]

Thank you all for helping with this!

@jsternberg done.

[jsternberg]

@pires you should give yourself credit in the changelog.

Can you also squash them into a single commit? Thanks.

[pires]

@jsternberg done! 😂

[jsternberg]

+1 I'll merge when the tests finish running.