Fix tag parsing #5382
Merged
Fix tag parsing #5382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-dard
force-pushed
the
fix-tag-parsing
branch
from
1ea7271
to
8564673
Compare
|
@jsternberg Can you take a look as well? @e-dard Looks good. Can you update the changelog as well? |
e-dard
force-pushed
the
fix-tag-parsing
branch
2 times, most recently
from
30fc54a
to
f997f16
Compare
|
@jwilder updated |
| // of bytes, starting from i and ending with stop byte, where stop byte | ||
| // has not been escaped. | ||
| // | ||
| // If there are leading spaces, they are skipped. |
There was a problem hiding this comment.
Can you remove the extra space at the beginning of this docstring?
e-dard
force-pushed
the
fix-tag-parsing
branch
from
f997f16
to
58a42cb
Compare
|
If you can just squash the commits, this looks good to me 👍 |
e-dard
force-pushed
the
fix-tag-parsing
branch
from
58a42cb
to
789aff9
Compare
|
Done |
|
👍 and merging since @jwilder gave his +1 too. |
|
@e-dard nice fixes! let me know if you find yourself bored over the next two weeks. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #5380 and #5381.
I've added a new type to the test package, which allows for more robust testing by validating that the tags you specify in your expected case are what you get from the processed point. Prior to this the bugs were being introduced to the expected tags values because one had to use
point.Tags()to retrieve them.Heads up: anywhere that skips a buffer by two places when the current byte is
\(as inif buf[i] == '\\' { i +=2 }) is possibly hiding a bug. I'd be happy to look in more detail at the Points/tags/fields stuff in a couple of weeks when I come on board @jwilder.