Adding support for matching tags multiple times in Graphite parser

[m4ce]

Original ticket #5416

[jwilder]

Graphite doesn't have a concept of a host so hard coding a special host tag doesn't make sense to me. It seems like you want to be able to define a tag multiple times in a template and match/combine them?

[m4ce]

@jwilder,

well, the current use case I have only involves host, which is easy since the separator should always be dot. But yes, the first thing that came to mind was to match tags multiple times, but then what separator to use?

Thanks,
Matteo

[jwilder]

@m4ce I understand. The issue is that host is too specific for your use case for this plugin. We'd have to generalize the PR to work with other tags for this to be able to be merged.

For separator, there is already a separator config option that should be used. By default, it's ..

[m4ce]

@jwilder,

I'm not a go developer, so I did what I could :) I hope the changes are good enough.

Thank you,
Matteo

[m4ce]

Any plan to merge this in the next release? Currently, I am deploying a custom binary around which is sub-optimal :)

[chrusty]

I've got a PR which is kinda related to this, which allows you to wildcard the "field" name of each metric:

#5562

[jwilder]

@m4ce This looks better. We need to have some test cases for this code though. You could add one fairly easily to this test case: https://github.com/influxdata/influxdb/blob/master/services/graphite/parser_test.go#L34

[m4ce]

@jwilder, I've added a case which tests multiple tags. I hope that is sufficient! Thank you!

[jwilder]

Thanks @m4ce