Ensure non-interactive mode returns appropriate exit code #5495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Nice job on updating the error messages for the tests 😄. +1 |
|
Oh, almost forgot, please update the |
|
👍 |
e-dard
added a commit
that referenced
this pull request
Feb 2, 2016
Ensure non-interactive mode returns appropriate exit code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5475.
ParseCommandnow returns an error, instead of abool. To indicate an empty commandErrBlankCommandis returned. In the case of non-interactive mode, errors fromParseCommandwill result in a non-zero exit code.Also some refactoring to the tests to improve coverage.