Fixes #5545 #5590
Merged
Fixes #5545 #5590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Tested and it works 👍 |
| @@ -574,8 +574,7 @@ func (data *Data) CreateSubscription(database, rp, name, mode string, destinatio | |||
| rpi, err := data.RetentionPolicy(database, rp) | |||
| if err != nil { | |||
| return err | |||
| } | |||
| if rpi == nil { | |||
| } else if rpi == nil { | |||
There was a problem hiding this comment.
nit: I think golint prefers not having the else as it was previously written.
|
minor nit (that I'm not 100% sure on). +1 |
|
@corylanou |
|
+1 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor out the
SUBSCRIPTIONtests for some better coverage and clarity. Ensure that a retention policy error will be returned if you attempt to drop a subscription on a policy that doesn't exist.Removed
meta.ErrRetentionPolicyNotFoundsince everything else usesinfluxdb. ErrRetentionPolicyNotFound()