Allow multiple Collectd plugin listeners #6090
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 5, 2016
|
@mengelmann Just found this PR after opening up a similar one (#6228). This looks good to me but will need a review by a couple of the core devs. |
|
This would conflict with #6228, which does a little bit more cleanup and includes an additional service. |
|
@joelegasse sure, if PR #6228 (@gunnaraasen) has better code than this one and it's more likely to be merged, then it's fine with me. We have use case that needs multiple collectd listeners and having it in the upstream version without patching is the most important for me, regardless whose PR is used :) |
|
It looks like #6228 was merged instead. I'm going to close this PR. Thanks for contributing anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to feature request #2785 "Some services should be able to have multiple instances". Code based on the multiple Graphite listeners.