Update to conversion tool to work in current versions #6159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelegasse
force-pushed
the
jl-influx-tsm
branch
from
536e74d
to
7ad0dc8
Compare
| @@ -33,6 +33,8 @@ type Value interface { | |||
| Value() interface{} | |||
| Size() int | |||
| String() string | |||
|
|
|||
| internalOnly() | |||
There was a problem hiding this comment.
To prevent using custom Value implementations?
There was a problem hiding this comment.
Yes, it makes sure that all tsm1.Values are created by this package.
After adding type-switches to the tsm1 packages, the custom implementation found in the conversion tool broke. This change uses tsm1.NewValue() instead of a custom implementation. This change also ensures that the tsm1.Value interface can only be implemented internally to allow for the optimized type-switch based encoding
joelegasse
force-pushed
the
jl-influx-tsm
branch
from
7ad0dc8
to
f10c300
Compare
|
👍 on green. |
|
Oh. Needs changelog update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6104, #6135, #6100, #6092, and probably others
After adding type-switches to the tsm1 packages, the custom
implementation found in the conversion tool broke. This change uses
tsm1.NewValue() instead of a custom implementation.
This change also ensures that the tsm1.Value interface can only be
implemented internally to allow for the optimized type-switch based
encoding