Add ability to copy shard via rpc calls. Remove deprecated copier service. #6502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
corylanou
commented
Apr 29, 2016
•
corylanou
commented
- Rebased/mergable
- Tests pass
- CHANGELOG.md updated
- Removes deprecated copier service
- adds plumbing for backup/restore via rpc
|
By analyzing the blame information on this pull request, we identified @e-dard, @mark-rushakoff and @gunnaraasen to be potential reviewers |
|
All of the plumbing was written by @benbjohnson I just made it work with the current version of this code. I'll be doing some testing to make sure it works across nodes and then I'll ask for reviews once I know it really works. |
|
I've decided that we should review and ship this otherwise I'll have a gigantic PR to merge before I'm done. |
| // Encode success response. | ||
| if err := EncodeTLV(conn, copyShardResponseMessage, &CopyShardResponse{}); err != nil { | ||
| s.Logger.Printf("error writing CopyShard response: %s", err) | ||
| return |
There was a problem hiding this comment.
I defensively added that in case code was added in the future after the if block. That's just my personal preference though.
|
I have a question I'll ask out-of-band, but aside from that LGTM 👍 |
corylanou
changed the title
corylanou
force-pushed
the
copy-shard
branch
2 times, most recently
from
eaa27fe
to
c3f3310
Compare
|
Needs a rebase but SLGTM 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.