Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add port to [graphite] log output #6834

Merged
merged 1 commit into from
Jun 14, 2016
Merged

Add port to [graphite] log output #6834

merged 1 commit into from
Jun 14, 2016

Conversation

jackzampolin
Copy link
Contributor

Required for all non-trivial PRs
  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated
  • Sign CLA (if not already signed)

If you have multiple [[graphite]] listeners it can be difficult to debug write errors because the port is not listed on the endpoint.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @e-dard to be a potential reviewer

@jackzampolin
Copy link
Contributor Author

jackzampolin commented Jun 14, 2016

Current output:

  • [graphite] {log_message}
  • [graphite] 2016/05/03 03:44:37 unable to parse line: : received " " which doesn't have required fields

New output:

  • [graphite] {port} {log_message}
  • [graphite] :2001 2016/05/03 03:44:37 unable to parse line: : received " " which doesn't have required fields

@jsternberg

@jsternberg
Copy link
Contributor

👍 Seems good to me.

@jackzampolin
Copy link
Contributor Author

@balopat

@jackzampolin jackzampolin merged commit a96f96c into master Jun 14, 2016
@jackzampolin jackzampolin deleted the jz-graphite branch June 14, 2016 18:35
@jsternberg
Copy link
Contributor

@jackzampolin can you make another commit with an update to the changelog for this? I forgot to check for that when I was reviewing this.

@jackzampolin jackzampolin restored the jz-graphite branch June 14, 2016 20:44
@jackzampolin jackzampolin deleted the jz-graphite branch June 14, 2016 20:45
@timhallinflux timhallinflux added this to the 1.0.0 milestone Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants