Copy tags in influx_stress to avoid a concurrent write panic on a map #7032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
js-fix-influx-stress-concurrent-write-panic
branch
2 times, most recently
from
746efb8
to
be2ade8
Compare
| @@ -678,8 +678,11 @@ func (o *outputConfig) HTTPHandler(method string) func(r <-chan response, rt *Ti | |||
| Precision: "ns", | |||
| }) | |||
| for p := range r { | |||
| tags := make(map[string]string) | |||
There was a problem hiding this comment.
make(map[string]string, len(o.tags)
There was a problem hiding this comment.
The reason why I didn't do that is because then we would likely want to take a lock on the tags so that len(o.tags) doesn't have a race condition. I didn't want to take a lock while allocating memory when I don't think it will have a substantial difference in performance as the size of the map is so small.
jsternberg
force-pushed
the
js-fix-influx-stress-concurrent-write-panic
branch
from
be2ade8
to
fc326b1
Compare
|
jsternberg
force-pushed
the
js-fix-influx-stress-concurrent-write-panic
branch
2 times, most recently
from
cda0ef5
to
b1fdf27
Compare
|
Not sure why this failed on AppVeyor. 👍 on green. |
jsternberg
force-pushed
the
js-fix-influx-stress-concurrent-write-panic
branch
2 times, most recently
from
472ab3f
to
94b6885
Compare
Removing lock from the same object as that object never does anything except for having attributes read.
jsternberg
force-pushed
the
js-fix-influx-stress-concurrent-write-panic
branch
from
94b6885
to
ccd1bd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.