Write path stats #7172
Closed
Write path stats #7172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename *Fail to *Err for consistency with other metrics * Use index Series count instead of sepaate counter
|
👍 |
|
Closing this since it was supposed to be for 1.0. Re-opened as: #7233 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all non-trivial PRs
This PR adds some simple write path success/error counts from the shard down to the cache and WAL. This allows someone to monitor the shard write OPS and detect when writes are failing. If they are failing, it can be determined by drilling down to the cache or WAL write stats.
This also fixes a bug in the cache size stat where deletes would not reset the memory usage.