Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper password field. Fix #7285. #7286

Merged
merged 1 commit into from Sep 14, 2016
Merged

Proper password field. Fix #7285. #7286

merged 1 commit into from Sep 14, 2016

Conversation

dandv
Copy link
Contributor

@dandv dandv commented Sep 10, 2016

This should let the admin interface integrate with the browser's password manager.

@mention-bot
Copy link

@dandv, thanks for your PR! By analyzing the annotation information on this pull request, we identified @gunnaraasen to be a potential reviewer

@jsternberg
Copy link
Contributor

Can you amend the commit with a changelog entry that gives yourself credit? See other examples in the changelog where it says Thanks.

Thanks!

Also, just a tip, GitHub won't link issues unless the text is in the body. It doesn't look at titles so you want to put the text at the end of your description.

Fixes #7285.

@jsternberg
Copy link
Contributor

/cc @toddboom

(I deleted a previous comment, got the wrong Todd because I remembered the wrong username)

@toddboom
Copy link
Contributor

Looks like the CLA is signed.

@dandv Thanks for the fix!

@toddboom
Copy link
Contributor

Also, AppVeyor failed on TestServer_Query_DefaultDBAndRP, which can't possibly be related.

@toddboom toddboom merged commit 5df0643 into influxdata:master Sep 14, 2016
toddboom added a commit that referenced this pull request Sep 14, 2016
Regenerate static assets and update CHANGELOG for PR #7286.
@dandv dandv deleted the patch-1 branch September 14, 2016 08:14
@dandv
Copy link
Contributor Author

dandv commented Sep 14, 2016

Thanks for the merge!

@jsternberg: OK to credit myself in the changelog for the next PR, hopefully something more significant?

@toddboom
Copy link
Contributor

@dandv already took care of it, should be in master right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants