Skip past points at the same time in derivative call within a merged series #7293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test for this? |
…series The derivative() call would panic if it received two points at the same time because it tried to divide by zero. The derivative call now skips past these points. To avoid skipping past these points, use `GROUP BY *` so that each series is kept separated into their own series. The difference() call has also been modified to skip past these points. Even though difference doesn't divide by the time, difference is supposed to perform the same as derivative, but without dividing by the time.
jsternberg
force-pushed
the
js-7110-cannot-use-derivative-function
branch
from
6c0a04e
to
0b94f5d
Compare
|
Added some tests, found an error, and now I think it works correctly (and it has a test to confirm that). |
jwilder
approved these changes
Sep 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The derivative() call would panic if it received two points at the same
time because it tried to divide by zero. The derivative call now skips
past these points. To avoid skipping past these points, use
GROUP BY *so that each series is kept separated into their own series.
The difference() call has also been modified to skip past these points.
Even though difference doesn't divide by the time, difference is
supposed to perform the same as derivative, but without dividing by the
time.
Fixes #7110.