Support ON and use default database for SHOW commands #7295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a changelog entry and probably needs a docs PR update. LGTM otherwise. |
|
👍 |
Normalize all of the SHOW commands so they allow both using ON to specify the database and using the default database. Some commands would require one and some would require the other and it was confusing when using the query language. Affected commands: * SHOW RETENTION POLICIES * SHOW MEASUREMENTS * SHOW SERIES * SHOW TAG KEYS * SHOW TAG VALUES * SHOW FIELD KEYS
jsternberg
force-pushed
the
js-6962-specify-database-in-schema-exploration-queries
branch
from
928c43f
to
aae88fc
Compare
jsternberg
deleted the
js-6962-specify-database-in-schema-exploration-queries
branch
|
@jsternberg presumably the old style commands still work, this just adds new, consistent syntax? |
|
@beckettsean yep. And if you see any other commands you want this done to, just file an issue and I'll do them too. |
|
@jsternberg can you add |
jsternberg
added a commit
that referenced
this pull request
Nov 1, 2016
The parser was updated previously in #7295 and the functionality was supposed to be there, but the wiring in the query engine for that to happen was never written.
This was referenced Nov 1, 2016
jsternberg
added a commit
that referenced
this pull request
Nov 1, 2016
The parser was updated previously in #7295 and the functionality was supposed to be there, but the wiring in the query engine for that to happen was never written.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalize all of the SHOW commands so they allow both using ON to
specify the database and using the default database. Some commands would
require one and some would require the other and it was confusing when
using the query language.
Affected commands:
Fixes #6962.