Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce query planning allocations #7385

Merged
merged 2 commits into from
Oct 3, 2016
Merged

Reduce query planning allocations #7385

merged 2 commits into from
Oct 3, 2016

Commits on Sep 29, 2016

  1. Avoid extra allocations when evalating binary expressions

    @jwilder
    jwilder committed Sep 29, 2016
    Configuration menu
    Copy the full SHA
    a3fd121 View commit details
    Browse the repository at this point in the history

  2. Reduce allocations when calculating tagsets 

    The TagSets function was creating a lot of intermediate maps and
slices to calculate the sorted tag sets.  It first creates a map
to group tag sets with their series, it then created an equally
sized slice of the tag keys and sorted then.  Finally, it created
a new slice and added the tag sets in the original map by the ordering
of the sorted keys.  It was also recreating the tags map multiple time
creating extra garbage in the loop.

This simplifies the code to create one map for grouping and than adding
the distinct sets to a slice which is then sorted.  It also fixes the
multple tag maps getting created.
    @jwilder
    jwilder committed Sep 29, 2016
    Configuration menu
    Copy the full SHA
    68dd312 View commit details
    Browse the repository at this point in the history