Ensure input services can be safely opened and closed #7463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-dard
force-pushed
the
er-services
branch
2 times, most recently
from
6cab812
to
d1f64da
Compare
e-dard
changed the title
e-dard
force-pushed
the
er-services
branch
3 times, most recently
from
701201c
to
fa4cb0b
Compare
jwilder
suggested changes
Oct 17, 2016
| if s.ln != nil { | ||
| return s.ln.Close() | ||
| if s.closed() { | ||
| s.Logger.Println("Service already closed.") |
There was a problem hiding this comment.
Remove? Not sure this really provides any value.
2 tasks
|
@jwilder ready for approval |
jwilder
approved these changes
Oct 18, 2016
| @@ -225,7 +257,7 @@ func (s *Service) Statistics(tags map[string]string) []models.Statistic { | |||
| } | |||
|
|
|||
| // Err returns a channel for fatal errors that occur on the listener. | |||
| func (s *Service) Err() <-chan error { return s.err } | |||
| // func (s *Service) Err() <-chan error { return s.err } | |||
There was a problem hiding this comment.
Eurgh sorry I meant to remove this function. Nothing calls it. I don't think we need it on the services do we @jwilder?
There was a problem hiding this comment.
If it's not used by anything, then it could be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all non-trivial PRs
This PR ensures that input services (
udp,graphite,opentsdbandcollectd) can be idempotently opened and closed.It also fixes a goroutine leak where a listener was not being closed properly.