Avoid deadlock when max-row-limit is hit #7606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
js-max-row-limit-block-fix
branch
2 times, most recently
from
40b66c3
to
66dcfc6
Compare
When the `max-row-limit` was hit, the goroutine reading from the results channel would stop reading from the channel, but it didn't signal to the sender that it was no longer reading from the results. This caused the sender to continue trying to send results even though nobody would ever read it and this created a deadlock. Include an `AbortCh` on the `ExecutionContext` that will signal when results are no longer desired so the sender can abort instead of deadlocking.
jsternberg
force-pushed
the
js-max-row-limit-block-fix
branch
from
66dcfc6
to
64c2d70
Compare
jwilder
approved these changes
Nov 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
max-row-limitwas hit, the goroutine reading from the resultschannel would stop reading from the channel, but it didn't signal to the
sender that it was no longer reading from the results. This caused the
sender to continue trying to send results even though nobody would ever
read it and this created a deadlock.
Include an
AbortChon theExecutionContextthat will signal whenresults are no longer desired so the sender can abort instead of
deadlocking.