Switch logging to use structured logging everywhere #7671
Conversation
jsternberg
force-pushed
the
js-7036-structured-logging
branch
6 times, most recently
from
336e3ab
to
844e612
Compare
jsternberg
force-pushed
the
js-7036-structured-logging
branch
from
844e612
to
4469dbc
Compare
jsternberg
force-pushed
the
js-7036-structured-logging
branch
from
4469dbc
to
666989c
Compare
There was a problem hiding this comment.
This is a step in the right direction. Without updating the log messages, I would go through this and remove the non-service context values in the filestore, cacheloader, and shard services. They duplicate information and really stretch out the log lines (especially with the file paths)
| func (s *Shard) SetLogOutput(w io.Writer) { | ||
| s.logger.SetOutput(w) | ||
| func (s *Shard) WithLogger(log zap.Logger) { | ||
| s.baseLogger = log.With( |
There was a problem hiding this comment.
This seems like only half of the change to switch to a full structured log. Without changing the current message being printed later on, it results in long messages with duplicated information:
[I] 2016-12-14T16:25:12Z /home/jlegasse/.influxdb/data/_internal/monitor/9 database index loaded in 8.860841ms shard=9 path=/home/jlegasse/.influxdb/data/_internal/monitor/9 service=shard
I think for this change, the extra context should be left out. We can revisit later and switch from formatted strings to zap context values all at once, then.
There was a problem hiding this comment.
Removed this, but kept the scaffolding code so it's easy to readd.
The logging library has been switched to use uber-go/zap. While the logging has been changed to use structured logging, this commit does not change any of the logging statements to take advantage of the new structured log or new log levels. Those changes will come in future commits.
jsternberg
force-pushed
the
js-7036-structured-logging
branch
from
666989c
to
21502a3
Compare
The logging library has been switched to use uber-go/zap. While the
logging has been changed to use structured logging, this commit does not
change any of the logging statements to take advantage of the new
structured log or new log levels. Those changes will come in future
commits.
Fixes #7036.