Fix broken return statements swallowing errors #7784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no comment on either case specifying that the `return nil` was deliberate instead of `return err`, so I'm assuming these were typos. I added tests to conserve the error-returning behavior.
mark-rushakoff
force-pushed
the
mr-meta-errors
branch
from
e459282
to
959c445
Compare
|
@corylanou your name came up on git blame for the changed lines. Does it seem accurate that these |
|
Doh! Those had to be cut/paste errors. Ugg. Nice catch. |
corylanou
approved these changes
Jan 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no comment on either case specifying that the
return nilwas deliberate instead of
return err, so I'm assuming these weretypos. I added tests to conserve the error-returning behavior.
Required for all non-trivial PRs