Use one atomic operation in (*Cache).decreaseSize #7786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-rushakoff
force-pushed
the
mr-cache-decrease-size
branch
2 times, most recently
from
e2bebf3
to
cd10f18
Compare
jwilder
reviewed
Jan 4, 2017
| atomic.StoreUint64(&c.size, size-delta) | ||
| // Since there isn't an explicit atomic operation for subtraction, | ||
| // use addition and overflow to effectively subtract delta from c.size. | ||
| atomic.AddUint64(&c.size, math.MaxUint64-delta+1) |
There was a problem hiding this comment.
nit: I think this is still correct, but the docs suggest a slightly shorter version:
atomic.AddUint64(&c.size, ^(delta-1))
There was a problem hiding this comment.
I overlooked that in the docs. I just pushed an amended commit to use that approach.
The previous implementation was susceptible to a race condition (of correctness) since c.decreaseSize is called without a lock in (*Cache).WriteMulti. There were already tests which asserted the correctness of the result of decreaseSize, so no tests were added or modified.
mark-rushakoff
force-pushed
the
mr-cache-decrease-size
branch
from
cd10f18
to
89a587e
Compare
jwilder
approved these changes
Jan 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation was susceptible to a race condition (of
correctness) since c.decreaseSize is called without a lock in
(*Cache).WriteMulti.
There were already tests which asserted the correctness of the result of
decreaseSize, so no tests were added or modified.