Maintain the tags of points selected by top() or bottom() when writing the results #8398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
js-7129-top-bottom-write-as-tags
branch
from
78095e1
to
d96d74a
Compare
|
I wanted to get this up to allow discussion about it and methods (along with letting those who are interested build the PR themselves), but this explicitly needs tests before it is merged. The existing tests ensure that it doesn't change current behavior for queries, but the new behavior is strange enough that the lack of tests is a blocker to merging. |
jsternberg
force-pushed
the
js-7129-top-bottom-write-as-tags
branch
3 times, most recently
from
d466587
to
10aae0b
Compare
jwilder
approved these changes
May 23, 2017
influxql/call_iterator.go
Outdated
| @@ -781,39 +781,47 @@ func IntegerSpreadReduceSlice(a []IntegerPoint) []IntegerPoint { | |||
| return []IntegerPoint{{Time: ZeroTime, Value: max - min}} | |||
| } | |||
|
|
|||
| func newTopIterator(input Iterator, opt IteratorOptions, n int) (Iterator, error) { | |||
| func newTopIterator(input Iterator, opt IteratorOptions, n int, writeMode bool) (Iterator, error) { | |||
There was a problem hiding this comment.
Should writeMode be named keepTags? Seems like that is what it indicates as opposed to having multiple values.
There was a problem hiding this comment.
That sounds fine to me. The name of the variable was rather arbitrary to begin with. I couldn't think of something good.
jsternberg
force-pushed
the
js-7129-top-bottom-write-as-tags
branch
from
10aae0b
to
a5bb16e
Compare
…g the results When a `SELECT ... INTO ...` is used with `top()` or `bottom()` used with tags, the points will be written with the tags still intact instead of converted to fields.
jsternberg
force-pushed
the
js-7129-top-bottom-write-as-tags
branch
from
a5bb16e
to
9edf236
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
SELECT ... INTO ...is used withtop()orbottom()used withtags, the points will be written with the tags still intact instead of
converted to fields.
Fixes #7129.