Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check file count before attempting a TSI level compaction. #8455

Merged

Conversation

benbjohnson
Copy link
Contributor

@benbjohnson benbjohnson commented Jun 6, 2017

Overview

This check was previously in a different section of code which was lost during a refactor to the new compaction strategy. The compaction planning now makes a check to ensure at least two files are available for compaction in a level.

Fixes #8451.

Required for all non-trivial PRs
  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated

@benbjohnson
Copy link
Contributor Author

I was trying to reproduce the issue but I didn't have any luck. This should fix it though.

This check was previously in a different section of code which
was lost during a refactor to the new compaction strategy. The
compaction planning now makes a check to ensure at least two
files are available for compaction in a level.
Copy link
Contributor

@e-dard e-dard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@benbjohnson benbjohnson merged commit 4957b3d into influxdata:master Jun 7, 2017
@benbjohnson benbjohnson deleted the tsi-level-file-count-check branch June 7, 2017 20:09
@benbjohnson benbjohnson removed the review label Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants