Fix TSI non-contiguous compaction panic. #8468
Merged
+43
−174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbjohnson
force-pushed
the
8459-fix-tsi-non-contiguous-compaction
branch
2 times, most recently
from
64fa20d
to
7a53a5c
Compare
This fixes the case where log files are compacted out of order and cause non-contiguous sets of index files to be compacted. Previously, the compaction planner would fetch a list of index files for each level and compact them in order starting with the oldest ones. This can be a problem for level 1 because level 0 (log files) are compacted individually and in some cases a log file can finish compacting before older log files are finished compacting. This causes there to be a gap in the list of level 1 files that is ignored when fetching a list of index files. Now, the planner reads the list of index files starting from the oldest but stops once it hits a log file. This prevents that gap from being ignored.
benbjohnson
force-pushed
the
8459-fix-tsi-non-contiguous-compaction
branch
from
7a53a5c
to
b51f604
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes the case where log files are compacted out of order and cause non-contiguous sets of index files to be compacted.
Previously, the compaction planner would fetch a list of index files for each level and compact them in order starting with the oldest ones. This can be a problem for level 1 because level 0 (log files) are compacted individually and in some cases a log file can finish compacting before older log files are finished compacting. This causes there to be a gap in the list of level 1 files that is ignored when fetching a list of index files.
Now, the planner reads the list of index files starting from the oldest but stops once it hits a log file. This prevents that gap from being ignored.
Fixes #8459.
Required for all non-trivial PRs