Fix time zone shifts when the shift happens on a time zone boundary #8610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
js-8607-time-zone-shifts
branch
from
d913f23
to
b15233f
Compare
jsternberg
force-pushed
the
js-8607-time-zone-shifts
branch
from
b15233f
to
174e642
Compare
When a time zone shift happened at the edge of a time bucket, the logic was incorrect. When we added an hour to the day with a time grouping of 2 hours, we took the hour away from the previous bucket instead of the next bucket so the first bucket of the day would be from midnight to 1 AM and the second bucket would include 1 AM to 4 AM (2 AM to 3 AM does not exist when shifting forwards). The correct buckets should have been 12 AM to 2 AM for the first bucket of the day and 3 AM to 4 AM for the second (since 2 AM to 3 AM does not exist). This also modifies the tests to use table tests and sub tests.
jsternberg
force-pushed
the
js-8607-time-zone-shifts
branch
from
174e642
to
343cd2e
Compare
desa
approved these changes
Jul 27, 2017
jsternberg
added a commit
that referenced
this pull request
Jul 28, 2017
When a time zone shift happened at the edge of a time bucket, the logic was incorrect. When we added an hour to the day with a time grouping of 2 hours, we took the hour away from the previous bucket instead of the next bucket so the first bucket of the day would be from midnight to 1 AM and the second bucket would include 1 AM to 4 AM (2 AM to 3 AM does not exist when shifting forwards). The correct buckets should have been 12 AM to 2 AM for the first bucket of the day and 3 AM to 4 AM for the second (since 2 AM to 3 AM does not exist). This also modifies the tests to use table tests and sub tests. Backport of #8610.
jsternberg
added a commit
that referenced
this pull request
Aug 8, 2017
When a time zone shift happened at the edge of a time bucket, the logic was incorrect. When we added an hour to the day with a time grouping of 2 hours, we took the hour away from the previous bucket instead of the next bucket so the first bucket of the day would be from midnight to 1 AM and the second bucket would include 1 AM to 4 AM (2 AM to 3 AM does not exist when shifting forwards). The correct buckets should have been 12 AM to 2 AM for the first bucket of the day and 3 AM to 4 AM for the second (since 2 AM to 3 AM does not exist). This also modifies the tests to use table tests and sub tests. Backport of #8610.
jsternberg
added a commit
that referenced
this pull request
Aug 10, 2017
When a time zone shift happened at the edge of a time bucket, the logic was incorrect. When we added an hour to the day with a time grouping of 2 hours, we took the hour away from the previous bucket instead of the next bucket so the first bucket of the day would be from midnight to 1 AM and the second bucket would include 1 AM to 4 AM (2 AM to 3 AM does not exist when shifting forwards). The correct buckets should have been 12 AM to 2 AM for the first bucket of the day and 3 AM to 4 AM for the second (since 2 AM to 3 AM does not exist). This also modifies the tests to use table tests and sub tests. Backport of #8610.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a time zone shift happened at the edge of a time bucket, the logic
was incorrect. When we added an hour to the day with a time grouping of
2 hours, we took the hour away from the previous bucket instead of the
next bucket so the first bucket of the day would be from midnight to 1
AM and the second bucket would include 1 AM to 4 AM (2 AM to 3 AM does
not exist when shifting forwards). The correct buckets should have been
12 AM to 2 AM for the first bucket of the day and 3 AM to 4 AM for the
second (since 2 AM to 3 AM does not exist).
This also modifies the tests to use table tests and sub tests.
Fixes #8607.