Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TimeRange function and replace with a more accurate ConditionExpr function #8712

Merged
merged 2 commits into from
Aug 16, 2017
Merged

Remove TimeRange function and replace with a more accurate ConditionExpr function #8712

merged 2 commits into from
Aug 16, 2017

Commits on Aug 16, 2017

  1. Remove TimeRange function and replace with a more accurate ConditionE… 

    …xpr function

The ConditionExpr function is more accurate because it parses the
condition and ensures that time conditions are actually used correctly.
That means that attempting to combine conditions with OR will not result
in the query silently pretending it's an AND and nested conditions work
correctly so there is only one way to read the query.

It also extracts the non-time conditions into a separate condition so we
can stop attempting to parse around the time conditions in lower layers
of the storage engine. This change does not remove those hacks, but a
following commit should be able to sanitize the condition and remove
them.
    @jsternberg
    jsternberg committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    8bd04eb View commit details
    Browse the repository at this point in the history

  2. Remove time comparisons from the inner sections of the storage engine

    @jsternberg
    jsternberg committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    6977596 View commit details
    Browse the repository at this point in the history