Use system cursors for measurement, series, and tag key meta queries. #8752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
approved these changes
Aug 28, 2017
| @@ -1066,6 +1066,12 @@ type SelectStatement struct { | |||
| // Removes the "time" column from the output. | |||
| OmitTime bool | |||
|
|
|||
| // Removes measurement name from resulting query. Useful for meta queries. | |||
| StripName bool | |||
There was a problem hiding this comment.
I'm not a big fan of adding these two options, but I don't see an alternative at the moment.
joelegasse
reviewed
Aug 28, 2017
influxql/statement_rewriter.go
Outdated
|
|
||
| func rewriteSources2(sources Sources, database string) Sources { | ||
| if len(sources) == 0 { | ||
| sources = Sources{&Measurement{Regex: &RegexLiteral{Val: regexp.MustCompile(`.+`)}}} |
There was a problem hiding this comment.
rather than recompiling the regex every time, the compilation can be done in an init() function, then Regexp.Copy() can be used here.
3 tasks
benbjohnson
force-pushed
the
1479-meta-queries
branch
from
5d9a62f
to
ab1cc37
Compare
benbjohnson
force-pushed
the
1479-meta-queries
branch
from
ab1cc37
to
1dbe066
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request changes several meta queries to use the new system cursors instead of the higher level system iterators used before. This allows the queries to filter based on time (with only shard-level time granularity).
This does not include
SHOW TAG VALUESorSHOW FIELD KEYS.Required for all non-trivial PRs