Sort & validate TSI key value insertion. #8995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
e-dard
approved these changes
Oct 23, 2017
| @@ -539,6 +543,13 @@ func (enc *TagBlockEncoder) EncodeValue(value []byte, deleted bool, seriesIDs [] | |||
| return fmt.Errorf("zero length tag value not allowed") | |||
| } | |||
|
|
|||
| // Validate that keys are in-order. | |||
There was a problem hiding this comment.
How often will we call EncodeValue? I only ask as this bytes.Compare call could be an expensive way to test the encoder is working properly. Or is returning an error a "normal path" for this encoder?
There was a problem hiding this comment.
It's called once for every tag value in the index. I think the cost should be relatively small compared to the merging and writing. We can remove it if it becomes a performance bottleneck but I think it'd be good to keep it in the short-term at least to ensure we don't store unsorted data.
benbjohnson
force-pushed
the
tsi-sort-log-tag-values
branch
from
ea68afa
to
2441748
Compare
benbjohnson
force-pushed
the
tsi-sort-log-tag-values
branch
from
2441748
to
5a77238
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The
TagBlockEncodervalue sorting was removed at some point and the underlying input was done via a range over a map which has unpredictable sorting. This fixes the sorting and adds additional validation to ensure inputs are always ordered when compacting index files.Required for all non-trivial PRs