Improve SHOW TAG KEYS performance. #9073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
e-dard
suggested changes
Nov 7, 2017
coordinator/statement_executor.go
Outdated
| @@ -932,6 +934,98 @@ func (e *StatementExecutor) executeShowSubscriptionsStatement(stmt *influxql.Sho | |||
| return rows, nil | |||
| } | |||
|
|
|||
| func (e *StatementExecutor) executeShowTagKeys(q *influxql.ShowTagKeysStatement, ctx *query.ExecutionContext) error { | |||
| var dis []meta.DatabaseInfo | |||
| if q.Database != "" { | |||
There was a problem hiding this comment.
I don't think that q.Database can be empty. The StatementRewriter should have set it I think. Did you encounter a case where it was empty?
There was a problem hiding this comment.
I think you're right. Not sure where I was thinking it could be empty. Fixed in 156f25a.
coordinator/statement_executor.go
Outdated
| } | ||
| dis = []meta.DatabaseInfo{*di} | ||
| } else { | ||
| dis = e.MetaClient.Databases() |
There was a problem hiding this comment.
I don't think SHOW TAG VALUES should work across databases.
There was a problem hiding this comment.
Fixed in 156f25a.
tsdb/store.go
Outdated
| switch e := e.(type) { | ||
| case *influxql.BinaryExpr: | ||
| // Remove time clause from condition | ||
| if ref, ok := e.LHS.(*influxql.VarRef); ok && strings.ToLower(ref.Val) == "time" { |
There was a problem hiding this comment.
The time clause should already be removed by influxql.ConditionExpr in the StatementExecutor I think.
There was a problem hiding this comment.
Removed in 156f25a.
benbjohnson
force-pushed
the
show-query-perf-2
branch
from
f1408bc
to
156f25a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all non-trivial PRs