shell shows error and usage when given extra parameters #9095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
mark-rushakoff
suggested changes
Nov 13, 2017
cmd/influx/main.go
Outdated
| @@ -108,6 +109,13 @@ Examples: | |||
| } | |||
| fs.Parse(os.Args[1:]) | |||
|
|
|||
| argsNotParsed := os.Args[len(os.Args)-fs.NArg():] | |||
| if len(argsNotParsed) > 0 { | |||
There was a problem hiding this comment.
This block should use flag.Args() instead.
https://golang.org/pkg/flag/#Arg
Args returns the non-flag command-line arguments.
|
@stop-start would you mind adding a line like to the 1.5.0 / Bugfixes section of CHANGELOG.md? |
|
@mark-rushakoff Done |
mark-rushakoff
approved these changes
Nov 13, 2017
|
Thanks @stop-start! |
|
Thanks @mark-rushakoff, it's my second pull request but first looked at and approved! |
|
The PR number in CHANGELOG.md is the wrong one, though. 9065 instead of 9095. |
|
Good catch @Luit, that was a typo on my part. Care to open a small PR to fix it? |
|
I opened a PR to fix it in #9182. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8593
When try to launch the shell with arguments the shell won't launch, instead will show an error (with the unknown args) as well as the usage.
Required for all non-trivial PRs