Go 1.10 omits Content-Type header if server response has no body #9208

stuartcarnie · 2017-12-08T02:20:13Z

Update error response to exclude Content-Type if body length is 0

https://tip.golang.org/doc/go1.10#net/http

The content-serving handlers also now omit the Content-Type header
when serving zero-length content.

Required for all non-trivial PRs

Rebased/mergable
Tests pass
CHANGELOG.md updated

https://tip.golang.org/doc/go1.10#net/http > The content-serving handlers also now omit the Content-Type header when serving zero-length content.

e-dard

LGTM 👍

Go 1.10 omits Content-Type if server response has no body

4f0c705

https://tip.golang.org/doc/go1.10#net/http > The content-serving handlers also now omit the Content-Type header when serving zero-length content.

stuartcarnie requested a review from e-dard December 8, 2017 02:20

ghost assigned stuartcarnie Dec 8, 2017

ghost added the review label Dec 8, 2017

update CHANGELOG

beef4e6

e-dard approved these changes Dec 8, 2017

View reviewed changes

stuartcarnie merged commit 0be32d5 into master Dec 8, 2017

ghost removed the review label Dec 8, 2017

stuartcarnie deleted the sgc-client branch December 8, 2017 17:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Go 1.10 omits Content-Type header if server response has no body #9208

Go 1.10 omits Content-Type header if server response has no body #9208

stuartcarnie commented Dec 8, 2017 •

edited

Loading

e-dard left a comment

Go 1.10 omits Content-Type header if server response has no body #9208

Go 1.10 omits Content-Type header if server response has no body #9208

Conversation

stuartcarnie commented Dec 8, 2017 • edited Loading

Required for all non-trivial PRs

e-dard left a comment

Choose a reason for hiding this comment

stuartcarnie commented Dec 8, 2017 •

edited

Loading