Do not explicitly specify ports 80 or 443 when they are the default port #9403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jsternberg
force-pushed
the
js-9259-influx-cli-port-fix
branch
from
b17a848
to
d8cccdf
Compare
mark-rushakoff
approved these changes
Feb 8, 2018
The default port for HTTP is 80 and HTTPS is 443. When you host InfluxDB on a service that uses a reverse proxy, the `Host` header needs to be exactly correct. Since the host header isn't expecting to see the port when it is the default, this causes routing to fail.
jsternberg
force-pushed
the
js-9259-influx-cli-port-fix
branch
from
d8cccdf
to
fab5c70
Compare
|
I forgot to add some tests so I just did that. Assuming they pass, I'll merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default port for HTTP is 80 and HTTPS is 443. When you host InfluxDB
on a service that uses a reverse proxy, the
Hostheader needs to beexactly correct. Since the host header isn't expecting to see the port
when it is the default, this causes routing to fail.
Fixes #9259.