Suppress the InfluxDB banner if the log output is not a TTY #9445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
stuartcarnie
changed the title
jsternberg
suggested changes
Feb 14, 2018
cmd/parse.go
Outdated
| @@ -27,3 +32,13 @@ func ParseCommandName(args []string) (string, []string) { | |||
| } | |||
| return "", args | |||
| } | |||
|
|
|||
| // IsTerminal checks if w is a file and whether it is an interactive terminal session. | |||
| func IsTerminal(w io.Writer) bool { | |||
There was a problem hiding this comment.
I think it would be better to just expose this method from the logger package rather than to copy it here.
jsternberg
changed the title
jsternberg
changed the title
stuartcarnie
force-pushed
the
sgc-nologo
branch
from
352c61f
to
8224b75
Compare
jsternberg
approved these changes
Feb 14, 2018
stuartcarnie
force-pushed
the
sgc-nologo
branch
from
8224b75
to
1303030
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the InfluxDB logo when output is redirected to a non-TTY device in order to strip extraneous data from log files.