Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.5: Revert "Use MADV_WILLNEED when loading TSM files" #9614

Merged
merged 1 commit into from
Mar 29, 2018
Merged

1.5: Revert "Use MADV_WILLNEED when loading TSM files" #9614

merged 1 commit into from
Mar 29, 2018

Conversation

benbjohnson
Copy link
Contributor

This reverts commit ee270e1.

@benbjohnson benbjohnson added this to the 1.5.2 milestone Mar 21, 2018
@benbjohnson benbjohnson self-assigned this Mar 21, 2018
@ghost ghost added the review label Mar 21, 2018
@benbjohnson benbjohnson mentioned this pull request Mar 21, 2018
Closed
@ghost ghost mentioned this pull request Mar 22, 2018
Closed
@benbjohnson benbjohnson merged commit b2b4515 into 1.5 Mar 29, 2018
@benbjohnson benbjohnson deleted the 1.5-bj-revert-madvise-willneed branch March 29, 2018 18:59
@ghost ghost removed the review label Mar 29, 2018
@shilicqupt
Copy link

shilicqupt commented Apr 9, 2018 •
edited
Loading

may i ask the reason for remove the madviseWillNeed(m.b) reason, indirectIndex warm-up is no better @benbjohnson

@benbjohnson
Copy link
Contributor Author

We were seeing 100x higher startup time on CentOS/RHEL with MADV_WILLNEED.

@e-dard e-dard mentioned this pull request Jul 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwilder jwilder jwilder approved these changes

Assignees

@benbjohnson benbjohnson

Labels
kind/bug
Projects
None yet
Milestone
1.5.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benbjohnson @shilicqupt @jwilder