Ensure that conditions are encoded correctly even if the AST is not properly formed #9676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roperly formed ConditionExpr would output conditions that may not have had parenthesis in the same place so they would not marshal into a proper expression. This fixes the condition before it gets encoded. This is done instead of fixing influxql because the current version of influxql is not compatible with 1.5 anymore and this version of influxdb doesn't have a very good way of using a branch. While it would be possible, this method is a more direct way to fix the problem for 1.5 and then fix it properly for 1.6.
ghost
assigned 
stuartcarnie
approved these changes
Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConditionExpr would output conditions that may not have had parenthesis
in the same place so they would not marshal into a proper expression.
This fixes the condition before it gets encoded.
This is done instead of fixing influxql because the current version of
influxql is not compatible with 1.5 anymore and this version of influxdb
doesn't have a very good way of using a branch. While it would be
possible, this method is a more direct way to fix the problem for 1.5
and then fix it properly for 1.6.