Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add suppress-write-log option to disable the write log when the log is enabled #9757

Merged
merged 1 commit into from
Apr 23, 2018
Merged

Add suppress-write-log option to disable the write log when the log is enabled #9757

merged 1 commit into from
Apr 23, 2018

Conversation

jsternberg
Copy link
Contributor

No description provided.

@ghost ghost assigned jsternberg Apr 23, 2018
@ghost ghost added the review label Apr 23, 2018
@jsternberg jsternberg mentioned this pull request Apr 23, 2018
Closed
7 tasks
mark-rushakoff
mark-rushakoff reviewed Apr 23, 2018
View reviewed changes
Copy link
Contributor

@mark-rushakoff mark-rushakoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to inject a logger to test that this config suppresses the logs?

@jsternberg
Copy link
Contributor Author

@mark-rushakoff done.

@jsternberg jsternberg merged commit 6d32539 into master Apr 23, 2018
@ghost ghost removed the review label Apr 23, 2018
@jsternberg jsternberg deleted the js-suppress-write-log branch April 23, 2018 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-rushakoff mark-rushakoff mark-rushakoff approved these changes

Assignees

@jsternberg jsternberg

Labels
kind/feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsternberg @mark-rushakoff