Return the correct auxiliary values for top/bottom #9858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
During a run of megacheck the following issues were discovered: |
stuartcarnie
requested changes
May 17, 2018
query/functions.go
Outdated
| heap.Fix(r.h, 0) | ||
| fmt.Println(r.h.points) |
query/functions.go
Outdated
| var clone FloatPoint | ||
| p.CopyTo(&clone) | ||
| heap.Push(r.h, clone) | ||
| fmt.Println(r.h.points) |
jsternberg
force-pushed
the
js-9197-top-return-correct-auxiliary-values
branch
from
30c0971
to
50614ec
Compare
|
During a run of megacheck the following issues were discovered: |
|
CI is failing: |
When `top()` or `bottom()` were used and selected auxiliary values, they would return the wrong values that would be equal to the last point selected. This is because the aggregators saved the memory address of the auxiliary fields instead of copying them over. Since the same auxiliary fields memory location is used for every value returned by the storage engine, this resulted in the values being incorrect because they were overwritten with incorrect values. This fixes that so the auxiliary fields are copied out when they are saved rather than only the memory location.
jsternberg
force-pushed
the
js-9197-top-return-correct-auxiliary-values
branch
from
50614ec
to
8a2bc63
Compare
|
Maybe that explains why megacheck has been failing. Fixed. |
|
During a run of megacheck the following issues were discovered: |
stuartcarnie
approved these changes
May 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
top()orbottom()were used and selected auxiliary values, theywould return the wrong values that would be equal to the last point
selected. This is because the aggregators saved the memory address of
the auxiliary fields instead of copying them over. Since the same
auxiliary fields memory location is used for every value returned by the
storage engine, this resulted in the values being incorrect because they
were overwritten with incorrect values.
This fixes that so the auxiliary fields are copied out when they are
saved rather than only the memory location.
Fixes #9197.