Improve the number of regex patterns that are optimized to static OR conditions #9959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jsternberg
force-pushed
the
js-9574-improve-rewrite-regex-conditions
branch
from
bfc6468
to
8552736
Compare
jsternberg
force-pushed
the
js-9574-improve-rewrite-regex-conditions
branch
2 times, most recently
from
2841702
to
ebda0f3
Compare
e-dard
suggested changes
Jun 15, 2018
Gopkg.toml
Outdated
| @@ -32,7 +32,7 @@ | |||
|
|
|||
| [[constraint]] | |||
| name = "github.com/influxdata/influxql" | |||
| revision = "145e0677ff6418fa00ee7e5dd434305631ab44ea" | |||
| revision = "8d2756c43bb02f5d3e505c51cf83a1ac9234c419" | |||
There was a problem hiding this comment.
We should change this to branch = master.
There was a problem hiding this comment.
This is always set to an exact revision so the same revision is inherited by the closed source version.
There was a problem hiding this comment.
I've removed this constraint. I'll create something in the closed source to watch for these kinds of things.
jsternberg
force-pushed
the
js-9574-improve-rewrite-regex-conditions
branch
from
ebda0f3
to
ed8001f
Compare
|
During a run of megacheck the following issues were discovered: |
jsternberg
force-pushed
the
js-9574-improve-rewrite-regex-conditions
branch
from
ed8001f
to
7962330
Compare
…conditions See influxdata/influxql#21 for details.
jsternberg
force-pushed
the
js-9574-improve-rewrite-regex-conditions
branch
from
7962330
to
b492b65
Compare
jsternberg
added a commit
that referenced
this pull request
Jun 22, 2018
…conditions Backport of #9959.
jacobmarble
pushed a commit
that referenced
this pull request
Jun 27, 2018
…conditions Backport of #9959.
jacobmarble
pushed a commit
that referenced
this pull request
Jun 27, 2018
…conditions Backport of #9959.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See influxdata/influxql#21 for details.
Fixes #9574.