TSM: Fix ShouldCompactCache without WAL #9972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
benbjohnson
approved these changes
Jun 13, 2018
jacobmarble
force-pushed
the
jgm-snapshot
branch
from
81c2063
to
544636c
Compare
10 tasks
jacobmarble
added a commit
that referenced
this pull request
Jun 26, 2018
TSM: Fix ShouldCompactCache without WAL
jacobmarble
added a commit
that referenced
this pull request
Jun 27, 2018
TSM: Fix ShouldCompactCache without WAL
jacobmarble
added a commit
that referenced
this pull request
Jun 27, 2018
TSM: Fix ShouldCompactCache without WAL
jacobmarble
added a commit
that referenced
this pull request
Jun 27, 2018
TSM: Fix ShouldCompactCache without WAL
jacobmarble
added a commit
that referenced
this pull request
Jun 27, 2018
TSM: Fix ShouldCompactCache without WAL
jacobmarble
added a commit
that referenced
this pull request
Jun 27, 2018
TSM: Fix ShouldCompactCache without WAL
jacobmarble
added a commit
that referenced
this pull request
Jun 27, 2018
TSM: Fix ShouldCompactCache without WAL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When WAL is disabled, snapshot compaction never happens due to
CacheFlushWriteColdDurationis exceeded, only whenCacheFlushMemorySizeThresholdis exceeded.This is a problem for quiet clusters that pull from Kafka, because Kafka has it's own retention policy; if Kafka cleans up before influxdb snapshots, and then influxdb terminates, then the cached data is lost.
This change depends on
Cache.LastWriteTimerather thanWAL.LastWriteTime, which are nearly identical anyway, becauseEngine.WritePointscallsCache.WriteMultijust beforeWAL.WriteMulti.